Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use after move to get exegesis annotator working in pipeline #249

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix use after move to get exegesis annotator working in pipeline #249

merged 2 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Fix use after move to get exegesis annotator working in pipeline 

    This patch fixes a user after move in BHiveToExegesis/related classes
where we would create a LLVMState, pass it into a couple other
constructors to create things that would store a reference to LLVMState,
and then promptly move it to call the BHiveToExegesis constructor. This
resulted in use after moves, which were ultimately caught by ubsan. This
patch fixes that behavior by encapsulating LLVMState within a unique_ptr
to prevent the problems.

The exegesis annotator is also enabled in the compile_modules invocation
script and test coverage is added now that it works.
    @boomanaiden154
    boomanaiden154 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ee350f4 View commit details
    Browse the repository at this point in the history

  2. Add perf counters tag

    @boomanaiden154
    boomanaiden154 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    410b5e3 View commit details
    Browse the repository at this point in the history