Add default benchmark scheduler #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 25, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 25, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 30, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
ondrasej
requested changes
Dec 30, 2024
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This reverts commit 86a1c06. I apparently accidentally fixed up google#271 into google#270. This reverts the changes that accidentally made there way into the tree. Pull Request: google#276
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
Created using spr 1.3.4
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
ondrasej
requested changes
Jan 16, 2025
Created using spr 1.3.4
ondrasej
approved these changes
Jan 16, 2025
ondrasej
requested changes
Jan 16, 2025
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Jan 16, 2025
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
Created using spr 1.3.4
boomanaiden154
added a commit
that referenced
this pull request
Jan 16, 2025
Created using spr 1.3.4 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.add-default-benchmark-scheduler
to
main
ondrasej
approved these changes
Jan 17, 2025
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Jan 17, 2025
This patch adds a default benchmark scheduler. This scheduler assumes the worker performing the benchmarking has three hyperthreads available inside its CPU mask, with two of them being part of a pair (from the same core). It then selects one core from the pair to be used for the benchmarking subprocess, and selects the core outside of the pair to be used to run the main exegesis/python program. Verification is also added to ensure that nothing external to the program changes the process mask, or at least to catch it early if it does happen. Pull Request: google#271
boomanaiden154
deleted the
users/boomanaiden154/add-default-benchmark-scheduler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a default benchmark scheduler. This scheduler assumes
the worker performing the benchmarking has three hyperthreads available
inside its CPU mask, with two of them being part of a pair (from the
same core). It then selects one core from the pair to be used for the
benchmarking subprocess, and selects the core outside of the pair to be
used to run the main exegesis/python program. Verification is also added
to ensure that nothing external to the program changes the process mask,
or at least to catch it early if it does happen.