-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move version to setup.py, fix enum34 requirement.
PiperOrigin-RevId: 204999443
- Loading branch information
Showing
2 changed files
with
8 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,22 +23,27 @@ | |
|
||
import codecs | ||
from os import path | ||
import gin | ||
import sys | ||
from setuptools import find_packages | ||
from setuptools import setup | ||
|
||
_VERSION = '0.1.1.2' | ||
|
||
here = path.abspath(path.dirname(__file__)) | ||
|
||
# Get the long description from the README file | ||
with codecs.open(path.join(here, 'README.md'), encoding='utf-8') as f: | ||
long_description = f.read() | ||
|
||
install_requires = ['six >= 1.10.0', 'enum34;python_version<"3.4"'] | ||
install_requires = ['six >= 1.10.0'] | ||
test_requirements = ['six >= 1.10.0', 'absl-py >= 0.1.6'] | ||
|
||
if sys.version_info < (3, 4): | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
sguada
Author
Collaborator
|
||
install_requires.append('enum34 >= 1.1.6') | ||
|
||
setup( | ||
name='gin-config', | ||
version=gin.__version__, | ||
version=_VERSION, | ||
include_package_data=True, | ||
packages=find_packages(exclude=['docs']), # Required | ||
package_data={'testdata': ['testdata/*.gin']}, | ||
|
This seems wrong.
enum34
is always installed even though I'm on Python 3.4+ if Ipip install gin-config
.(And probably you ran this setup.py with Python version below 3.4 to upload PYPI.)