Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog assumes that if gflags is available, it has been built with GFLAGS_USE_TARGET_NAMESPACE=OFF #683

Closed
bucurb opened this issue Jul 9, 2021 · 0 comments · Fixed by #684
Closed

glog assumes that if gflags is available, it has been built with GFLAGS_USE_TARGET_NAMESPACE=OFF #683

bucurb opened this issue Jul 9, 2021 · 0 comments · Fixed by #684
Assignees
@sergiud
Labels
enhancement
Milestone
0.6

Comments

@bucurb
Copy link

bucurb commented Jul 9, 2021

On this line:

glog/CMakeLists.txt

Line 633 in 42ce901

target_link_libraries (glog PUBLIC gflags)

the glog CMake target adds a dependency to the gflags CMake target. The latter is only available if gflags has been built with GFLAGS_USE_TARGET_NAMESPACE=OFF. Otherwise, the correct target is gflags::gflags. This is causing linker errors, see for instance this issue.
@bucurb bucurb mentioned this issue Jul 9, 2021
Merged
sergiud added a commit to sergiud/glog that referenced this issue Jul 13, 2021
@sergiud
cmake: prefer linking against gflags::gflags (fixes google#683)
5bf7fde
@sergiud sergiud mentioned this issue Jul 13, 2021
Merged
@sergiud sergiud self-assigned this Jul 13, 2021
@sergiud sergiud added this to the 0.6 milestone Jul 13, 2021
sergiud added a commit that referenced this issue Jul 14, 2021
@sergiud
Merge pull request #684 from sergiud/cmake-namespaced-gflags
a01d739 
cmake: prefer linking against gflags::gflags (fixes #683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiud sergiud

Labels
enhancement
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

cmake: prefer linking against gflags::gflags (fixes #683) sergiud/glog
2 participants
@sergiud @bucurb