Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall warning in Bazel build #717

Closed
ArthurBandaryk opened this issue Oct 7, 2021 · 4 comments · Fixed by #718
Closed

syscall warning in Bazel build #717

ArthurBandaryk opened this issue Oct 7, 2021 · 4 comments · Fixed by #718
Labels
bug
Milestone
0.6

Comments

@ArthurBandaryk
Copy link
Contributor

ArthurBandaryk commented Oct 7, 2021 •
edited
Loading

Hey guys! JFYI when I'm trying to build glog with bazel build :glog in macOS 11.4 I got the following warning:
Screen Shot 2021-10-07 at 2 27 25 PM
Is there a way to fix this warning?
ty:)
ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 7, 2021
@ArthurBandaryk
Added copts_ list
3cd65f8 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
@ArthurBandaryk ArthurBandaryk mentioned this issue Oct 7, 2021
Closed
@sergiud sergiud added the invalid label Oct 7, 2021
@sergiud
Copy link
Collaborator

sergiud commented Oct 7, 2021

#185

@sergiud sergiud closed this as completed Oct 7, 2021
@drigz
Copy link
Member

drigz commented Oct 7, 2021

I'm not sure this is invalid: I think bazel/glog.bzl might need to set HAVE_PTHREAD_THREADID_NP and OS_MACOSX to benefit from #685. Am I missing something?

@ArthurBandaryk You could look into adding those to darwin_only_copts. If that fixes the warning for you, please send a PR!

ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 7, 2021
@ArthurBandaryk
Added copts_ list
88ba132 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
@ArthurBandaryk ArthurBandaryk mentioned this issue Oct 7, 2021
Merged
@sergiud
Copy link
Collaborator

sergiud commented Oct 7, 2021

@drigz Good catch. I missed that the problem is related to Bazel.

@sergiud sergiud reopened this Oct 7, 2021
@sergiud sergiud changed the title syscall warning syscall warning in Bazel build Oct 7, 2021
@ArthurBandaryk
Copy link
Contributor Author

ArthurBandaryk commented Oct 7, 2021 •
edited
Loading

Hey @drigz ! First of all I would like to thank you, your idea to add 2 options HAVE_PTHREAD_THREADID_NP and OS_MACOSX in the darwin_only_copts helped me:)
Screen Shot 2021-10-07 at 4 06 02 PM
So it fixed this warning!
Screen Shot 2021-10-07 at 4 06 19 PM
So, I will do a PR!
ty!

ArthurBandaryk added a commit to ArthurBandaryk/glog that referenced this issue Oct 7, 2021
@ArthurBandaryk
Fix syscall warning in Bazel Build
c941dec 
This commit resolves [google#717](google#717) issue.
@ArthurBandaryk ArthurBandaryk mentioned this issue Oct 7, 2021
Merged
ArthurBandaryk added a commit to ArthurBandaryk/glog that referenced this issue Oct 7, 2021
@ArthurBandaryk
Fix syscall warning in Bazel Build
46ae27e 
This commit resolves [google#717](google#717) issue.
ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 7, 2021
@ArthurBandaryk
Added copts_ list
1ce3954 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
drigz added a commit to drigz/glog that referenced this issue Oct 7, 2021
@drigz
Add -Werror to Bazel presubmits
321ebb1 
This avoids issues like google#717.
@drigz drigz mentioned this issue Oct 7, 2021
Merged
drigz added a commit to drigz/glog that referenced this issue Oct 7, 2021
@drigz
Add -Werror to Bazel presubmits
8594dbe 
This avoids issues like google#717.
drigz added a commit to drigz/glog that referenced this issue Oct 7, 2021
@drigz
Add -Werror to Bazel presubmits
329f6d9 
This avoids issues like google#717.
@sergiud sergiud added this to the 0.6 milestone Oct 7, 2021
@drigz drigz closed this as completed in #718 Oct 7, 2021
drigz pushed a commit that referenced this issue Oct 7, 2021
@ArthurBandaryk @drigz
Fix syscall warning in Bazel Build
c34dbe9 
This commit resolves [#717](#717) issue.
drigz added a commit to drigz/glog that referenced this issue Oct 7, 2021
@drigz
Add -Werror to Bazel presubmits
ed14894 
This avoids issues like google#717.
drigz added a commit that referenced this issue Oct 7, 2021
@drigz
Add -Werror to Bazel presubmits
831a6f8 
This avoids issues like #717.
ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 8, 2021
@ArthurBandaryk
Added copts_ list
c305b77 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 8, 2021
@ArthurBandaryk
Added copts_ list
57faa6c 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
ArthurBandaryk added a commit to 3rdparty/eventuals that referenced this issue Oct 13, 2021
@ArthurBandaryk
Added copts_ list
358acda 
`copts_` list contains `-Werror` option in order to turn all warnings into the
errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning
into a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about `syscall` warning
[#717](google/glog#717).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Fix syscall warning in Bazel Build ArthurBandaryk/glog
3 participants
@drigz @sergiud @ArthurBandaryk