Fix demangling template parameter packs #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 4.0.1-10 and gcc 7.3.0 both mangle the function "void add<int>(int)" as "_Z3addIJiEEvDpT_". The template parameter pack is of the form J <template-arg>* E The opening character for a param pack could be either I or J, as libiberty follows [1]. This change simply adds the J case. [1] https://github.com/gcc-mirror/gcc/blob/fbd263526ad105a953fd51d9f7bca2c3f268cf82/libiberty/cp-demangle.c#L3209
hlsyounes
suggested changes
Jan 4, 2019
Done |
|
Thanks for the review. Could you also merge this for me? I don't think I have permission to do it myself |
|
I don't have permission either. I think you need one of the members in this group to do the merge: I'll ping them, since I have a pull request of my own that fixes the other outstanding issue with the demangle unit test. |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
* Fix demangling template parameter packs Clang 4.0.1-10 and gcc 7.3.0 both mangle the function "void add<int>(int)" as "_Z3addIJiEEvDpT_". The template parameter pack is of the form J <template-arg>* E The opening character for a param pack could be either I or J, as libiberty follows [1]. This change simply adds the J case. [1] https://github.com/gcc-mirror/gcc/blob/fbd263526ad105a953fd51d9f7bca2c3f268cf82/libiberty/cp-demangle.c#L3209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 4.0.1-10 and gcc 7.3.0 both mangle the function "void add<int>(int)" as
"_Z3addIJiEEvDpT_". The template parameter pack is of the form
J <template-arg>* E
The opening character for a param pack could be either I or J, as libiberty
follows [1]. This change simply adds the J case.
[1] https://github.com/gcc-mirror/gcc/blob/fbd263526ad105a953fd51d9f7bca2c3f268cf82/libiberty/cp-demangle.c#L3209