Allow CMake user to disable Symbolize functionality #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbaunton
force-pushed
the
cmake-have-symbolize
branch
from
511ae2d to
4be041c
Compare
|
On the platform I am testing on which doesn't have dladdr functionality, I think I am falling foul of this check which I think could simply be rewritten as:
because the CMake Documentation reports that However I am not familiar enough to know whether that logic is like that for some hidden reason. |
sergiud
requested changes
Feb 8, 2020
Currently the user has to rely on the HAVE_SYMBOLIZE detection inside CMakeLists.txt without having any control over whether it should be used. Add support for disabling HAVE_SYMBOLIZE at configure time so user can specify `cmake -DHAVE_SYMBOLIZE=0`. Signed-off-by: Ed Baunton <ebaunton1@bloomberg.net>
edbaunton
force-pushed
the
cmake-have-symbolize
branch
from
4be041c to
eb13e4f
Compare
|
Made the changes. |
sergiud
approved these changes
Mar 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user has to rely on the HAVE_SYMBOLIZE detection inside
CMakeLists.txt without having any control over whether it should be used.
Add support for disabling HAVE_SYMBOLIZE at configure time so user can specify
cmake -DHAVE_SYMBOLIZE=0.Signed-off-by: Ed Baunton ebaunton1@bloomberg.net