Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: update CMake source directory option #642

Merged
merged 1 commit into from
Apr 14, 2021
Merged

readme: update CMake source directory option #642

merged 1 commit into from
Apr 14, 2021

Conversation

husskade
Copy link
Contributor

@husskade husskade commented Apr 9, 2021

-H flag has been replaced in 3.13 with the official source directory flag of -S.

@google-cla
Copy link

google-cla bot commented Apr 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sergiud
Copy link
Collaborator

sergiud commented Apr 12, 2021

Thanks. However, we cannot merge this PR if you don't sign the CLA.

@sergiud sergiud closed this Apr 12, 2021
@husskade
Copy link
Contributor Author

@googlebot I signed it!

@sergiud sergiud reopened this Apr 14, 2021
@husskade
Copy link
Contributor Author

Thanks. However, we cannot merge this PR if you don't sign the CLA.

I've signed it, but it seems to check doesn't recognize it.

@sergiud
Copy link
Collaborator

sergiud commented Apr 14, 2021

You might need to answer the bot again. If that still does not work, I guess you'll need to create a new PR.

@husskade
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 14, 2021
@husskade
Copy link
Contributor Author

You might need to answer the bot again. If that still does not work, I guess you'll need to create a new PR.

It worked, thanks.

@sergiud
Copy link
Collaborator

sergiud commented Apr 14, 2021

Could you please update your commit message and describe what actually changed and maybe why? Update README.rst as a commit message is not helpful.

@husskade
Copy link
Contributor Author

Could you please update your commit message and describe what actually changed and maybe why? Update README.rst as a commit message is not helpful.

Done.

The `-H` command-line option has been replaced in 3.13 by `-S`.
@sergiud
Copy link
Collaborator

sergiud commented Apr 14, 2021

Thanks!

@sergiud sergiud added this to the 0.5 milestone Apr 14, 2021
@sergiud sergiud changed the title Update README.rst readme: update CMake source directory option Apr 14, 2021
@sergiud sergiud merged commit 8d40d75 into google:master Apr 14, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants