Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating vmodule levels after vmodule level has been cached #650

Merged
merged 1 commit into from
May 23, 2021
Merged

Allow updating vmodule levels after vmodule level has been cached #650

merged 1 commit into from
May 23, 2021

Conversation

romange
Copy link
Contributor

@romange romange commented May 10, 2021 •
edited
Loading

We maintain a linked list of all sites so we could invalidate those that should change upon SetVLOGLevel call.
Once site level starts pointing to module override it will be removed from the linked list to avoid unnecessary traversals.

Fixes #649

@google-cla google-cla bot added the cla: yes label May 10, 2021
@romange
Copy link
Contributor Author

romange commented May 10, 2021

@sergiud I can not see why windows build is failing and I do not have a windows machine to test it. Could you help pointing out the problem?

@sergiud
Copy link
Collaborator

sergiud commented May 11, 2021

Thanks for the PR. I will look into the failures. The ctest output does not provide any apparent cues why the test fails specifically under Windows.

@sergiud
Copy link
Collaborator

sergiud commented May 14, 2021 •
edited
Loading

The test fails because TestVlogHelper returns 0 instead of 1. Looks like VLOG_IS_ON does not work as expected.

@sergiud sergiud added the bug label May 14, 2021
@romange romange force-pushed the Prod branch 2 times, most recently from e6e93d6 to 4f4190a Compare May 23, 2021 14:55
@romange
Allow updating vmodule levels after vmodule was parsed, invalidate al…
86fea1a 
…ready cached site flags

vmodule flag is relevant for GNUC environments only.
@romange
Copy link
Contributor Author

romange commented May 23, 2021

@sergiud it should pass now. PTAL

@sergiud sergiud added this to the 0.6 milestone May 23, 2021
@sergiud sergiud self-assigned this May 23, 2021
@sergiud
Copy link
Collaborator

sergiud commented May 23, 2021

Thanks!

@sergiud sergiud merged commit 03f2b38 into google:master May 23, 2021
@hari90 hari90 mentioned this pull request Sep 7, 2022
Open
@ByteYue ByteYue mentioned this pull request Dec 22, 2023
Merged
@sergiud sergiud mentioned this pull request Jan 5, 2024
Closed
@hari90 hari90 mentioned this pull request Jun 21, 2024
Open
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
c89717a 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
00df55f 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
bff316c 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
0a0f41d 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
7c468c9 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
998f03e 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Jul 12, 2024
@stdpain
[Enhancement] upgrade some thirdparty
28c274f 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
kevincai pushed a commit to kevincai/starrocks that referenced this pull request Jul 25, 2024
@stdpain @kevincai
[Enhancement] upgrade some thirdparty
518c130 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
kevincai pushed a commit to kevincai/starrocks that referenced this pull request Jul 29, 2024
@stdpain @kevincai
[Enhancement] upgrade some thirdparty
28fbea2 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <drfeng08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiud sergiud sergiud left review comments

Assignees

@sergiud sergiud

Labels
bug cla: yes
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

SetVLOGLevel does not work if VLOG_IS_ON has already cached its module level
2 participants
@romange @sergiud