log messages periodically (time-based) #669

darbitman · 2021-06-13T22:24:46Z

Closes #663

Use constexpr if c++11, otherwise const
If C++11 (or greater), provide an implementation to log every time period T using std::chrono and std::atomic
For pre-C++11, use struct timespec from <ctime> or <time.h> on Linux platforms. On Windows platforms, use QueryPerformanceCounter and QueryPerformanceFrequency

sergiud

Thanks for the PR. Could you please add tests?

src/glog/logging.h.in

darbitman · 2021-06-26T17:35:12Z

Thanks for the PR. Could you please add tests?

Done. hopefully they're sufficient.

sergiud · 2021-06-26T19:28:10Z

There are some build failures.

src/glog/logging.h.in

src/logging_unittest.cc

sergiud

Looks mostly fine. I still have a few remarks. Could you please eventually squash the commits?

bazel/glog.bzl

src/glog/logging.h.in

sergiud · 2021-07-04T19:11:59Z

src/logging_unittest.cc

+  return stream;
+}
+// get elapsed time in microseconds
+int64 elapsedTime_us(const timespec& begin, const timespec& end) {


This is something I previously overlooked. Wouldn't it make sense to always you the highest possible precision in ns?

Not for this particular test, because the error tolerance is 500us and any variation in the hundreds of nanoseconds is insignificant. That being said, I'll go back and change to nanoseconds to remove some of the math just to simply the functions.

darbitman · 2021-07-04T20:46:07Z

Looks mostly fine. I still have a few remarks. Could you please eventually squash the commits?

Yeah I'll do that.

One last thing...
I have the HAVE_CXX11_CHRONO guard in logging_unittest.cc:1016, but I realized I removed that from the config.h.in. How do you think I should proceed since you mentioned that the config.h macros are really used internally?

sergiud · 2021-07-04T20:51:12Z

You can still define HAVE_CXX11_CHRONO in the config.h.cmake.in if you need it.

darbitman · 2021-07-04T20:55:24Z

That'll be plan B. Do you think it's fair to say for OS_LINUX (or as the #else clause to an #ifdef OS_WINDOWS) I can just use struct timespec even if <chrono> exists and keep the implementation for OS_WINDOWS as is?

sergiud · 2021-07-04T22:06:15Z

I would prefer <chrono> over platform specific functionality.

src/glog/logging.h.in

Use <chrono> and <atomic> for C++11 or greater. For non-Windows pre-C++11 systems, use <time.h> and built-in atomic operations. For Windows pre-C++11, use the Windows implementations for time and atomic operations.

sergiud · 2021-07-05T18:32:59Z

Thanks!

google-cla bot added the cla: yes label Jun 13, 2021

darbitman marked this pull request as ready for review June 16, 2021 02:16

sergiud requested changes Jun 16, 2021

View reviewed changes

src/glog/logging.h.in Outdated Show resolved Hide resolved

src/glog/logging.h.in Outdated Show resolved Hide resolved

darbitman marked this pull request as draft June 16, 2021 13:10

darbitman force-pushed the log-every-time-period branch from b8ef152 to 447b97d Compare June 26, 2021 17:33

darbitman marked this pull request as ready for review June 26, 2021 17:33

darbitman marked this pull request as draft June 29, 2021 03:36

darbitman marked this pull request as ready for review July 2, 2021 01:42

sergiud requested changes Jul 3, 2021

View reviewed changes

src/glog/logging.h.in Outdated Show resolved Hide resolved

src/glog/logging.h.in Outdated Show resolved Hide resolved

src/glog/logging.h.in Outdated Show resolved Hide resolved

src/logging_unittest.cc Outdated Show resolved Hide resolved

darbitman force-pushed the log-every-time-period branch 2 times, most recently from 497f1f4 to fd83d3c Compare July 3, 2021 19:31

sergiud requested changes Jul 4, 2021

View reviewed changes

darbitman force-pushed the log-every-time-period branch from 3b244db to ff2269a Compare July 5, 2021 03:55

sergiud requested changes Jul 5, 2021

View reviewed changes

src/glog/logging.h.in Outdated Show resolved Hide resolved

Implement LOG_EVERY_T.

a1374c4

Use <chrono> and <atomic> for C++11 or greater. For non-Windows pre-C++11 systems, use <time.h> and built-in atomic operations. For Windows pre-C++11, use the Windows implementations for time and atomic operations.

darbitman force-pushed the log-every-time-period branch from ff2269a to a1374c4 Compare July 5, 2021 14:25

sergiud self-assigned this Jul 5, 2021

sergiud added this to the 0.6 milestone Jul 5, 2021

sergiud approved these changes Jul 5, 2021

View reviewed changes

sergiud merged commit 42ce901 into google:master Jul 5, 2021

sergiud mentioned this pull request Jul 14, 2021

Does glog support one log per day? #644

Closed

sergiud mentioned this pull request Jan 7, 2024

Why not add something like FB_LOG_EVERY_MS into glog? #884

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

log messages periodically (time-based) #669

log messages periodically (time-based) #669

darbitman commented Jun 13, 2021 •

edited

Loading

sergiud left a comment

darbitman commented Jun 26, 2021

sergiud commented Jun 26, 2021

sergiud left a comment •

edited

Loading

sergiud Jul 4, 2021

darbitman Jul 4, 2021

darbitman commented Jul 4, 2021

sergiud commented Jul 4, 2021

darbitman commented Jul 4, 2021 •

edited

Loading

sergiud commented Jul 4, 2021

sergiud commented Jul 5, 2021

log messages periodically (time-based) #669

log messages periodically (time-based) #669

Conversation

darbitman commented Jun 13, 2021 • edited Loading

sergiud left a comment

Choose a reason for hiding this comment

darbitman commented Jun 26, 2021

sergiud commented Jun 26, 2021

sergiud left a comment • edited Loading

Choose a reason for hiding this comment

sergiud Jul 4, 2021

Choose a reason for hiding this comment

darbitman Jul 4, 2021

Choose a reason for hiding this comment

darbitman commented Jul 4, 2021

sergiud commented Jul 4, 2021

darbitman commented Jul 4, 2021 • edited Loading

sergiud commented Jul 4, 2021

sergiud commented Jul 5, 2021

darbitman commented Jun 13, 2021 •

edited

Loading

sergiud left a comment •

edited

Loading

darbitman commented Jul 4, 2021 •

edited

Loading