Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an static cast to compare unsigned with unsigned #696

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

Fettpet
Copy link

@Fettpet Fettpet commented Aug 8, 2021

Problem:
The count variable is an unsigned integer. The result of the numeric_limit::max() call is a signed integer. The gcc with -Wall parameter warns about this compare.

Solution:
The result of the numeric_limit::max call is cast to an unsigned value. This prevents that the gcc warns about the compare.

@google-cla
Copy link

google-cla bot commented Aug 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 8, 2021
@Fettpet
Copy link
Author

Fettpet commented Aug 8, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Aug 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Fettpet
Copy link
Author

Fettpet commented Aug 8, 2021

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 8, 2021
@sergiud
Copy link
Collaborator

sergiud commented Aug 9, 2021

There's a typo in your commit message: "an static [...]".

@sergiud sergiud merged commit 35983c8 into google:master Aug 10, 2021
@sergiud
Copy link
Collaborator

sergiud commented Aug 10, 2021

Thanks!

@sergiud sergiud added this to the 0.6 milestone Aug 10, 2021
@Fettpet Fettpet deleted the signed_compare branch August 10, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants