ci: replace generated headers by templates #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drigz I got in touch with the Coveralls support team because the PR comments still do not appear. They were very helpful at tracing the problem to a disabled setting in the web interface. Specifically, the PR comments must be enabled at https://coveralls.io/github/google/glog/settings under "Pull Requests Alerts": |
drigz
approved these changes
Oct 12, 2021
sergiud
force-pushed
the
coverage-use-templates
branch
from
8250c00 to
06e6651
Compare
|
@drigz Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, coverage analysis runs particularly on generated headers. However, since these are not readily available for Coveralls their source cannot be displayed prohibiting their online inspection.
This PR patches the coverage files by replacing the paths of generated headers by their template sources.