added log cleaner tests and fixed paths #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesophor
reviewed
Dec 6, 2021
| dirs = GetLoggingDirectories(); | ||
| } else { | ||
| size_t pos = base_filename.find_last_of(possible_dir_delim, 0, | ||
| sizeof(possible_dir_delim)); |
There was a problem hiding this comment.
Hello @sergiud, I think the arguments passed to find_last_of is incorrect:
- line 1333-1334 would only search
base_filenamefor any char in possible_dir_delim starting at index 0 for n characters, where n =sizeof(possible_dir_delim)(and in this case n = 1) - I think only the first argument is needed.
There was a problem hiding this comment.
Thanks. Do you have a specific test case in mind that triggers the problem? Or even better, could you submit directly a PR?
There was a problem hiding this comment.
Yes I have one!
I called SetLogDestination(INFO, “testdir/”) and came across this problem. I’ll submit a PR.
#include <glog/logging.h>
int main(int argc, char *argv[]) {
google::InitGoogleLogging(argv[0]);
google::SetLogDestination(google::INFO, "testdir/");
google::EnableLogCleaner(1);
LOG(INFO) << "msg";
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for #654.