Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/s3blob: support URL query parameters to override aws.Config fields #1359

Merged
merged 16 commits into from
Feb 28, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Feb 15, 2019

Fixes #1357.

@vangent vangent requested a review from zombiezen February 15, 2019 23:04
@googlebot googlebot added the cla: yes Google CLA has been signed! label Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #1359 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   76.28%   76.25%   -0.04%     
==========================================
  Files          57       57              
  Lines        4390     4418      +28     
==========================================
+ Hits         3349     3369      +20     
- Misses        882      890       +8     
  Partials      159      159
Impacted Files Coverage Δ
aws/aws.go 0% <0%> (ø) ⬆️
blob/s3blob/s3blob.go 86.68% <73.33%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a974fe5...2d36d70. Read the comment docs.

zombiezen added a commit to zombiezen/go-cloud that referenced this pull request Feb 21, 2019
Copy link
Contributor

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Robert! I agree with adding the region parameter, but I'm not as onboard with other changes in this PR. I'd like to decouple a few (I realize you were on a time crunch), but I think we can wait to get this right. Stepping through:

blob/gcsblob/gcsblob_test.go Outdated Show resolved Hide resolved
blob/s3blob/s3blob.go Show resolved Hide resolved
blob/s3blob/s3blob.go Outdated Show resolved Hide resolved
@vangent
Copy link
Contributor Author

vangent commented Feb 25, 2019

PTAL

@vangent vangent requested a review from zombiezen February 26, 2019 20:43
@vangent
Copy link
Contributor Author

vangent commented Feb 26, 2019

I can also update this to set SharedConfigEnable, LMK.

@vangent
Copy link
Contributor Author

vangent commented Feb 27, 2019

Gentle ping @zombiezen ...

@zombiezen
Copy link
Contributor

Decided offline: we'll make the SharedConfigEnable in a separate PR. We should also change the *Session that's in the default provider sets. @vangent, can you file an issue for that?

@vangent
Copy link
Contributor Author

vangent commented Feb 28, 2019

Decided offline: we'll make the SharedConfigEnable in a separate PR. We should also change the *Session that's in the default provider sets. @vangent, can you file an issue for that?

Done:
#1416

@vangent vangent merged commit 31355ab into google:master Feb 28, 2019
@vangent vangent deleted the s3queryparams branch February 28, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants