-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blob/s3blob: support URL query parameters to override aws.Config fields #1359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 76.28% 76.25% -0.04%
==========================================
Files 57 57
Lines 4390 4418 +28
==========================================
+ Hits 3349 3369 +20
- Misses 882 890 +8
Partials 159 159
Continue to review full report at Codecov.
|
Suggested by @vangent in google#1359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Robert! I agree with adding the region
parameter, but I'm not as onboard with other changes in this PR. I'd like to decouple a few (I realize you were on a time crunch), but I think we can wait to get this right. Stepping through:
PTAL |
I can also update this to set |
Gentle ping @zombiezen ... |
Decided offline: we'll make the |
Fixes #1357.