Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob: add URL schemes for gcsblob and s3blob #605

Merged
merged 4 commits into from
Nov 2, 2018
Merged

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Nov 1, 2018

Fixes #423.

@vangent vangent requested a review from jba November 1, 2018 23:33
@googlebot googlebot added the cla: yes Google CLA has been signed! label Nov 1, 2018
blob/gcsblob/gcsblob.go Outdated Show resolved Hide resolved
blob/gcsblob/gcsblob.go Show resolved Hide resolved
blob/s3blob/s3blob.go Outdated Show resolved Hide resolved
@vangent vangent closed this Nov 2, 2018
@vangent vangent reopened this Nov 2, 2018
@vangent
Copy link
Contributor Author

vangent commented Nov 2, 2018

Travis got stuck, made a minor comment change to kickstart it.

@vangent vangent closed this Nov 2, 2018
@vangent vangent reopened this Nov 2, 2018
@vangent vangent closed this Nov 2, 2018
@vangent vangent reopened this Nov 2, 2018
@vangent vangent closed this Nov 2, 2018
@vangent vangent reopened this Nov 2, 2018
@vangent vangent removed the cla: yes Google CLA has been signed! label Nov 2, 2018
@googlebot googlebot added the cla: yes Google CLA has been signed! label Nov 2, 2018
@vangent vangent merged commit 2152f20 into google:master Nov 2, 2018
@vangent vangent deleted the url branch November 2, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants