Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mutation of image or index media types #624

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #491

For reasons that are fun to explain, I need this for ko-build/ko#38 to work with GCR, as well 😄

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #624 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   76.27%   76.37%   +0.09%     
==========================================
  Files         101      101              
  Lines        4397     4415      +18     
==========================================
+ Hits         3354     3372      +18     
  Misses        633      633              
  Partials      410      410
Impacted Files Coverage Δ
pkg/v1/types/types.go 100% <ø> (ø) ⬆️
pkg/v1/mutate/mutate.go 74.56% <100%> (+1.23%) ⬆️
pkg/v1/mutate/index.go 76.81% <100%> (+1.81%) ⬆️
pkg/v1/mutate/image.go 68.75% <100%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7c14b...3bfede6. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 73724ba into google:master Dec 9, 2019
@jonjohnsonjr jonjohnsonjr deleted the mutate-media-type branch December 9, 2019 17:32
jonjohnsonjr added a commit to jonjohnsonjr/go-containerregistry that referenced this pull request Dec 16, 2019
jonjohnsonjr added a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add the ability to mutate MediaType
3 participants