Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete layout blob #936

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Delete layout blob #936

merged 1 commit into from
Feb 8, 2021

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Feb 8, 2021

We already can WriteBlob, so we should be able to RemoveBlob.

@deitch deitch force-pushed the delete-layout-blob branch from 63e634b to 54d29d0 Compare February 8, 2021 09:56
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine beyond my one nit. Happy to merge if you add a unit test.

pkg/v1/layout/write.go Outdated Show resolved Hide resolved
@deitch deitch force-pushed the delete-layout-blob branch from 54d29d0 to 4f2e54d Compare February 8, 2021 17:42
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the delete-layout-blob branch from 4f2e54d to 65200ba Compare February 8, 2021 17:51
@deitch
Copy link
Collaborator Author

deitch commented Feb 8, 2021

Test in place too

@jonjohnsonjr jonjohnsonjr merged commit cbafe63 into google:main Feb 8, 2021
@jonjohnsonjr
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants