Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update references to use go 1.15 #943

Closed
wants to merge 1 commit into from
Closed

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Feb 22, 2021

In the GH actions, it is already using go 1.15.x was missing to update go in two places.

/assign @jonjohnsonjr

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@imjasonh
Copy link
Collaborator

Does it make sense to include 1.16 as well?

@cpanato
Copy link
Contributor Author

cpanato commented Feb 22, 2021

if all agree I can update all the references to be 1.16

@jonjohnsonjr
Copy link
Collaborator

Let's stick with 1.15 for now? We used to have a matrix of tests in travis, but we've lost that. If we could test both 1.15 and 1.16, I'd be happy.

@cpanato
Copy link
Contributor Author

cpanato commented Feb 22, 2021

@jonjohnsonjr i can look and implement the CI GO test matrix using GitHub actions

@jonjohnsonjr
Copy link
Collaborator

That would be phenomenal -- we dropped travis in #922

@cpanato
Copy link
Contributor Author

cpanato commented Mar 12, 2021

gently ping @jonjohnsonjr

@jonjohnsonjr
Copy link
Collaborator

I'm not 100% clear on what the go version really means in go.mod. Is it the minimum version at which the module will build? When are you supposed to update it? It's hard to google for this stuff :/

@cpanato
Copy link
Contributor Author

cpanato commented Mar 12, 2021

me too, but I use that to set my env to the appropriate go version

but I think that implies to the minimum go version that is required

@jonjohnsonjr
Copy link
Collaborator

I found golang/go#30791 which seems to agree but I haven't read the whole thing.

Do we know the minimum go version? I'm reluctant to bump this unless we really need to, because it might break folks on go1.14 for no reason...

@cpanato
Copy link
Contributor Author

cpanato commented Mar 12, 2021

I dont have strong opinions. feel free to close this PR if you want

@cpanato
Copy link
Contributor Author

cpanato commented Apr 21, 2021

@jonjohnsonjr I will close this PR, if we decided to update the references I can make another one

@cpanato cpanato closed this Apr 21, 2021
@cpanato cpanato deleted the update-go branch April 21, 2021 12:05
@jonjohnsonjr
Copy link
Collaborator

Thanks - I think we'll want to bump eventually, but I don't have any kind of policy for compatibility with go versions in mind quite yet.

@jonjohnsonjr
Copy link
Collaborator

Actually... I'd be happy to bump the version used in the release to 1.16, given that there are some performance improvements in the compiler from 1.14 -> 1.15 and 1.15 -> 1.16.

My only issue is with the go.mod thing, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants