ListRepositoryWorkflowRuns doesn't support all query parameters #1497
Comments
acburdine
added a commit
to acburdine/go-github
that referenced
this issue
Apr 20, 2020
closes google#1497 - update the method to use the more specific ListWorkflowRunsOptions struct
acburdine
added a commit
to acburdine/go-github
that referenced
this issue
Apr 20, 2020
closes google#1497 - update the method to use the more specific ListWorkflowRunsOptions struct
|
Sounds good to me, @acburdine - thank you! |
gmlewis
pushed a commit
that referenced
this issue
Apr 20, 2020
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this issue
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that the ActionsService.ListRepositoryWorkflowRuns function doesn't currently support passing in all of the available query parameters for the actual API call, because it's currently using the generic
ListOptionsstruct. The other two ListWorkflowRuns* functions are using aListWorkflowRunsOptionsstruct that has all of the supported query parameters listed.According to the docs it appears all of the options in
ListWorkflowRunsOptionsare supported by the ListRepositoryWorkflowRuns endpoint. My thinking is that this was either missed in the original implementation, or that Github added support for the additional parameters recently - either way, is there a reason that the function can't be updated to useListWorkflowRunsOptions?The text was updated successfully, but these errors were encountered: