-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Repository Vulnerability alert patch #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is used to store payload of repository_vulnerability_alert webhook event.
repository_vulnerability_alert event type is mapped to RepositoryVulnerabilityAlertEvent struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @akhilerm!
This looks great to me.
LGTM.
Awaiting second LGTM before merging.
github/event_types.go
Outdated
// | ||
// GitHub API docs: https://developer.github.com/v3/activity/events/types/#repositoryvulnerabilityalertevent | ||
type RepositoryVulnerabilityAlertEvent struct { | ||
// Action is the action that was performed. This can be: "create", "dismiss", "resolve" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please add period to end of sentence for godocs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
period added and pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for the PR 👍
Thank you, @gauntface! |
PR for issue #1005. Thanks @gmlewis, @gauntface for helping me make my first PR in a Google repo. |
Added struct for
repository_vulnerability_alert
webhook event, as mentioned in docs.Made changes where the payload is assigned and mapping done from webhook event to new struct.