Skip to content

Repository Vulnerability alert patch #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2018

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Oct 3, 2018

Added struct for repository_vulnerability_alert webhook event, as mentioned in docs.

Made changes where the payload is assigned and mapping done from webhook event to new struct.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 3, 2018
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @akhilerm!
This looks great to me.
LGTM.
Awaiting second LGTM before merging.

//
// GitHub API docs: https://developer.github.com/v3/activity/events/types/#repositoryvulnerabilityalertevent
type RepositoryVulnerabilityAlertEvent struct {
// Action is the action that was performed. This can be: "create", "dismiss", "resolve"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add period to end of sentence for godocs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

period added and pushed.

@gmlewis gmlewis requested a review from gauntface October 4, 2018 03:31
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the PR 👍

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 4, 2018

Thank you, @gauntface!
Merging.

@gmlewis gmlewis merged commit 4c1b69f into google:master Oct 4, 2018
@akhilerm
Copy link
Contributor Author

akhilerm commented Oct 4, 2018

PR for issue #1005.

Thanks @gmlewis, @gauntface for helping me make my first PR in a Google repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants