Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Workflow to use pointers #1437

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Switch Workflow to use pointers #1437

merged 1 commit into from
Feb 22, 2020

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 22, 2020

I approved and merged #1411 which implements Workflows without pointers to fields which is inconsistent with the rest of the repo.

In light of #1429, #537, #180, #79, #45, and #19, I'm creating this PR to be more consistent with the repo.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Feb 22, 2020
@gmlewis gmlewis requested a review from gauntface February 22, 2020 12:30
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 22, 2020

@wesleimp or @martinssipenko - feel free to review/approve since you worked on similar PRs.

Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 22, 2020

Thank you, @wesleimp!
Merging.

@gmlewis gmlewis merged commit 2f9ce45 into google:master Feb 22, 2020
@gmlewis gmlewis deleted the fix-1411 branch February 22, 2020 14:40
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants