Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repository to the RepositoryVulnerabilityAlertEvent struct #1496

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Add Repository to the RepositoryVulnerabilityAlertEvent struct #1496

merged 2 commits into from
Apr 20, 2020

Conversation

ryanwi
Copy link
Contributor

@ryanwi ryanwi commented Apr 20, 2020

The RepositoryVulnerabilityAlertEvent payload includes the Repository key which is important to add context to the Alert. The alert by itself does not capture what repo the alert is on.

https://developer.github.com/v3/activity/events/types/#repositoryvulnerabilityalertevent

{
    "action": "create",
    "alert": {
      "id": 271940701,
      "affected_range": "< 2.2.3",
      "affected_package_name": "https-proxy-agent",
      "external_reference": "https://github.com/TooTallNate/node-https-proxy-agent/commit/36d8cf509f877fa44f4404fce57ebaf9410fe51b",
      "external_identifier": "WS-2019-0310",
      "ghsa_id": "GHSA-pc5p-h8pf-mvwp",
      "created_at": "2020-04-16T22:28:10Z",
      "fixed_in": "2.2.3"
    },
    "repository": {
// repo details here
    }

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ryanwi ryanwi marked this pull request as ready for review April 20, 2020 00:44
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 20, 2020

Thank you, @ryanwi.

Two things need to be done before we can move forward with this (see CONTRIBUTING.md for more details):

  • go generate ./...
  • sign the Google CLA

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1496 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files          94       94           
  Lines        8452     8452           
=======================================
  Hits         5764     5764           
  Misses       1819     1819           
  Partials      869      869           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca0dcc...2cecaa5. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ryanwi!
LGTM.
Merging.

@gmlewis gmlewis changed the title Adds Repository to the RepositoryVulnerabilityAlertEvent struct Add Repository to the RepositoryVulnerabilityAlertEvent struct Apr 20, 2020
@gmlewis gmlewis merged commit 8ac6f14 into google:master Apr 20, 2020
@ryanwi
Copy link
Contributor Author

ryanwi commented Apr 20, 2020

Wow, that was fast @gmlewis, thank you!

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 20, 2020

Thank you, @ryanwi! We appreciate all contributions to help keep this repo up-to-date.

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants