-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix: Remove Sort & Direction Fields From IssueListCommentsOptions" #1857
Conversation
This reverts commit 512c583.
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 105 105
Lines 6764 6764
=======================================
Hits 6605 6605
Misses 86 86
Partials 73 73
Continue to review full report at Codecov.
|
@tamalsaha or @nightlark - if you could please review and approve this PR, that would be helpful. |
Thanks, LGTM! |
Thank you, @tamalsaha !
Actually, I just realized that this is not technically a breaking API change with the addition of missing fields... so I could much more easily release |
Yes. v35.1.0 sounds good to me. |
Excellent, thank you. |
Reverts #1584