Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: Remove Sort & Direction Fields From IssueListCommentsOptions" #1857

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Apr 24, 2021

Reverts #1584

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #1857 (5d4aed6) into master (b235769) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1857   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         105      105           
  Lines        6764     6764           
=======================================
  Hits         6605     6605           
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/issues_comments.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b235769...5d4aed6. Read the comment docs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Apr 24, 2021

@tamalsaha or @nightlark - if you could please review and approve this PR, that would be helpful.

@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). bug labels Apr 24, 2021
@tamalsaha
Copy link

Thanks, LGTM!

@gmlewis gmlewis merged commit cceb4d4 into master Apr 24, 2021
@gmlewis gmlewis deleted the revert-1584-fix/remove-fields branch April 24, 2021 12:22
@gmlewis
Copy link
Collaborator Author

gmlewis commented Apr 24, 2021

Thank you, @tamalsaha !

Do you need me to cut a new v36 release?

Actually, I just realized that this is not technically a breaking API change with the addition of missing fields... so I could much more easily release v35.1.0 with this revert. Are you OK with that, @tamalsaha ?

@gmlewis gmlewis removed the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Apr 24, 2021
@tamalsaha
Copy link

Yes. v35.1.0 sounds good to me.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Apr 24, 2021

Excellent, thank you.
I went ahead and created v35.1.0: https://github.com/google/go-github/releases/tag/v35.1.0

This was referenced May 21, 2021
This was referenced Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants