-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app hook deliveries API #2226
Conversation
Can we re-run the cla job? I signed it but it hasn't updated 🤔 |
@googlebot - recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pierce-m !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.
Also, could you please send a message to @googlebot like "Hey @googlebot - I signed it." and let's see if it responds. Thanks again!
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
- Coverage 97.81% 97.79% -0.03%
==========================================
Files 112 113 +1
Lines 10117 10156 +39
==========================================
+ Hits 9896 9932 +36
- Misses 154 156 +2
- Partials 67 68 +1
Continue to review full report at Codecov.
|
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Looks like it updated with the new commits -- thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pierce-m !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
@wesleimp can I get some 👀 on this one please? |
@Parker77 - do you have time to take a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77! |
Resolves #2225