-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination options to list all package versions #2250
Add pagination options to list all package versions #2250
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2250 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 113 113
Lines 10207 10211 +4
=======================================
+ Hits 9983 9987 +4
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lpmatos !
Once you sign the CLA, we can move forward with this PR.
LGTM.
@gmlewis Do I have to commit using my gmail? I followed all the steps mentioned in the documentation. Sorry for the questions, this is my first contribution to a project like this. |
The CLA email needs to match the email address you associated with your GitHub commits, and it looks like you sorted it all out. Thanks. We are now ready for a second LGTM/Approval from any other contributor to this repo. Maybe @Parker77 has time to review this some time today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77 ! |
Here is the detail of the problem: #2251.