Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty #2289

Merged
merged 4 commits into from
Feb 14, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/repos.go
Original file line number Diff line number Diff line change
@@ -945,7 +945,7 @@ type PullRequestReviewsEnforcementUpdate struct {
// Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. Can be omitted.
DismissStaleReviews *bool `json:"dismiss_stale_reviews,omitempty"`
// RequireCodeOwnerReviews specifies if an approved review is required in pull requests including files with a designated code owner.
RequireCodeOwnerReviews bool `json:"require_code_owner_reviews,omitempty"`
RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"`
// RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged.
// Valid values are 1 - 6.
leopoldwang marked this conversation as resolved.
Show resolved Hide resolved
RequiredApprovingReviewCount int `json:"required_approving_review_count"`
leopoldwang marked this conversation as resolved.
Show resolved Hide resolved