Implement global security advisories API

[cpanato]

• implement global security advisories API

Fixes: #2851

cc @gmlewis

[gmlewis]

Thanks, @cpanato. I'm going to stop my code review early here and ask you to remove as many new structs that you've added as possible, and to instead reuse SecurityAdvisory and other related structs as much as possible without all the duplication.

Also, every new exported struct that you add needs a full godoc string.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (78c6de0) 97.93% compared to head (b0cc2f2) 97.91%.

Files	Patch %	Lines
github/security_advisories.go	89.28%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
- Coverage   97.93%   97.91%   -0.02%     
==========================================
  Files         150      150              
  Lines       12952    12980      +28     
==========================================
+ Hits        12685    12710      +25     
- Misses        190      192       +2     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cpanato]

@gmlewis thanks so much for your review and sorry about the force-push

[gmlewis]

OK, two small nits, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[cpanato]

@gmlewis Thanks again for your review, PTAL

[gmlewis]

Thank you, @cpanato !
LGTM after one tiny nit, after which we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[gmlewis]

Thank you, @cpanato !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[cpanato]

@gmlewis checking if you know how long this will take? :)
also, after we merge this when can we have a new release? thanks again

[gmlewis]

@cpanato - we rely on volunteers to help maintain this repo. I don't know when another contributor will be available to review this PR before merging. And yes, we should be able to make a new release soon as well.

[cpanato]

thank you @gmlewis, no worries just checking :)

[valbeat]

LGTM!

[gmlewis]

Thank you, @valbeat !
Merging.

[cpanato]

thanks for all the support

[gmlewis]

@gmlewis checking if you know how long this will take? :) also, after we merge this when can we have a new release? thanks again

Hi @cpanato - this is now released here: https://github.com/google/go-github/releases/tag/v57.0.0
Sorry for the delay.

[cpanato]

@gmlewis checking if you know how long this will take? :) also, after we merge this when can we have a new release? thanks again

Hi @cpanato - this is now released here: https://github.com/google/go-github/releases/tag/v57.0.0

Sorry for the delay.

No sorry is needed. Thank you for all the work you do here 🎉 and thanks for the release