Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permissions to struct #3349

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

tomfeigin
Copy link
Contributor

Added permissions:

  • repository_custom_properties
  • repository_advisories
  • merge_queues
  • discussions
  • dependabot_secrets
  • codespaces_secrets
  • codespaces_metadata
  • codespaces_lifecycle_admin
  • codespaces

Added permissions:
- repository_custom_properties
- repository_advisories
- merge_queues
- discussions
- dependabot_secrets
- codespaces_secrets
- codespaces_metadata
- codespaces_lifecycle_admin
- codespaces
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (aa98173).
Report is 171 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3349      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15031    +1641     
==========================================
+ Hits        13085    13874     +789     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin !
LGTM.
Merging.

@gmlewis gmlewis merged commit fbd682c into google:master Nov 17, 2024
6 of 7 checks passed
@tomfeigin
Copy link
Contributor Author

Hey @gmlewis when is the next version planned to be released? I would like to use the code in this PR in the library instead of maintaining my fork, if possible

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 27, 2024

@tomfeigin - I'll work on a release today.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 27, 2024

@tomfeigin - this is now released in v67:
https://github.com/google/go-github/releases/tag/v67.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants