Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PersonalAccessToken struct #3404

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

R4vio
Copy link
Contributor

@R4vio R4vio commented Dec 25, 2024

According to REST API: https://docs.github.com/en/rest/orgs/personal-access-tokens?apiVersion=2022-11-28#list-fine-grained-personal-access-tokens-with-access-to-organization-resources

There are some fields which are not getting captured by PersonalAccessToken struct. The fields are:

token_id
token_name

For issue: #3403

Copy link

google-cla bot commented Dec 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @R4vio !
LGTM.
Merging.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (2b8c7fa) to head (02a38b5).
Report is 209 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
- Coverage   97.72%   92.21%   -5.51%     
==========================================
  Files         153      173      +20     
  Lines       13390    14770    +1380     
==========================================
+ Hits        13085    13620     +535     
- Misses        215     1060     +845     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 25, 2024

@R4vio - please run step 4 in CONTRIBUTING.md and push the changes. (go generate ./...)

@R4vio
Copy link
Contributor Author

R4vio commented Dec 25, 2024

@gmlewis, did the steps in CONTRIBUTING.md, seems it was missing some accessors.

@gmlewis gmlewis merged commit 3424b98 into google:master Dec 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants