-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Spell "unmarshal" consistently with one el #3441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gmlewis could you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. Thank you, @alexandear and @stevehipwell !
LGTM
Merging.
Hmmm... I'm not seeing CodeCov run at all. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3441 +/- ##
==========================================
- Coverage 97.72% 92.26% -5.46%
==========================================
Files 153 174 +21
Lines 13390 15023 +1633
==========================================
+ Hits 13085 13861 +776
- Misses 215 1068 +853
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
The PR updates comments and error messages to use
unmarshal
with one el. Also, configuresmisspell
linter to detects this in the future.See https://go.dev//wiki/Spelling