Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Spell "unmarshal" consistently with one el #3441

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alexandear
Copy link
Contributor

The PR updates comments and error messages to use unmarshal with one el. Also, configures misspell linter to detects this in the future.

See https://go.dev//wiki/Spelling

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Contributor

@gmlewis could you take a look at this?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you, @alexandear and @stevehipwell !
LGTM
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

Hmmm... I'm not seeing CodeCov run at all.
I'm going to have to investigate once I get back to my computer.

@stevehipwell
Copy link
Contributor

https://github.com/google/go-github/actions/runs/12870419878/job/35881913304?pr=3441#step:8:209

@gmlewis gmlewis merged commit 4510383 into google:master Jan 20, 2025
5 checks passed
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (715c375).
Report is 225 commits behind head on master.

Files with missing lines Patch % Lines
github/repos_contents.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3441      +/-   ##
==========================================
- Coverage   97.72%   92.26%   -5.46%     
==========================================
  Files         153      174      +21     
  Lines       13390    15023    +1633     
==========================================
+ Hits        13085    13861     +776     
- Misses        215     1068     +853     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants