Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path escape fix in UserService.GetPackage() #3522

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Mar 18, 2025

  • Run liniting, testing commands
  • Modified the test to ensure the escape sequence.

Fixes: #3262.

Signed-off-by: Abinand P <abinand0911@gmail.com>
Copy link

google-cla bot commented Mar 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (8f3c64e) to head (687dc80).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3522   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         183      183           
  Lines       16099    16099           
=======================================
  Hits        14695    14695           
  Misses       1230     1230           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Abiji-2020!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 18, 2025
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 18, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 18, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit bcfcb89 into google:master Mar 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrganizationsService.GetPackage escapes packageName, but UserService.GetPackage does not
3 participants