Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ linters:
comparison: true
forbidigo:
forbid:
- pattern: ^fmt\.Print.*$
msg: "Do not use fmt.Print statements."
- pattern: ^reflect\.DeepEqual$
msg: "Use cmp.Equal instead of reflect.DeepEqual"
- pattern: "^http\\.Method[A-Z][a-z]*$"
Expand Down Expand Up @@ -359,6 +361,11 @@ linters:
- unparam
path: _test\.go

# Allow fmt.Print in examples, internal tools, and tests.
- linters: [forbidigo]
path: ^(example|tools|test|scrape)\/
text: 'fmt\.Print'

# We need to pass nil Context in order to test DoBare erroring on nil ctx.
- linters: [staticcheck]
path: _test\.go
Expand Down
2 changes: 0 additions & 2 deletions github/actions_variables_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,5 @@ func TestActionVariable_Marshal(t *testing.T) {
"selected_repository_ids": [1,2,3]
}`, referenceTimeStr, referenceTimeStr)

fmt.Println(want)

testJSONMarshal(t, av, want)
}
2 changes: 0 additions & 2 deletions github/enterprise_licenses_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ func TestEnterpriseService_GetLicenseSyncStatus(t *testing.T) {
},
}

fmt.Printf("%v\n", cmp.Diff(want, syncStatus))

if !cmp.Equal(syncStatus, want) {
t.Errorf("Enterprise.GetLicenseSyncStatus returned %+v, want %+v", syncStatus, want)
}
Expand Down
Loading