Skip to content

#638: Remove custom media type for Pull Request Reviews API #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2017
Merged

#638: Remove custom media type for Pull Request Reviews API #641

merged 2 commits into from
May 15, 2017

Conversation

varadarajana
Copy link
Contributor

@shurcooL I have made changes for the media type for the entire pulls reviews. Can you please review this?

@dmitshur
Copy link
Member

Look at #611 as an example of a PR that removes a custom media type that's no longer needed.

There's no need to set mediaTypeV3 in individual methods, because it's already set when a request is created. See

go-github/github/github.go

Line 263 in 4a42a1d

req.Header.Set("Accept", mediaTypeV3)
.

@varadarajana
Copy link
Contributor Author

@shurcooL Sorry I missed the GitHub.go file where the normal headers are already set. Here is the corrected file.

dmitshur
dmitshur approved these changes May 15, 2017
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@dmitshur dmitshur merged commit 1151660 into google:master May 15, 2017
bubg-dev pushed a commit to bubg-dev/go-github that referenced this pull request Jun 16, 2017
@varadarajana @dmitshur
Remove custom media type for Pull Request Reviews API. (google#641)
04a53a8 
The Pull Request Reviews API (include Review Requests) has become an
official part of GitHub API v3, so the preview API media type is no
longer needed. See announcement at
https://developer.github.com/changes/2017-05-09-end-black-cat-preview/.

Resolves google#638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitshur dmitshur dmitshur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varadarajana @dmitshur