Adds RequireCodeOwnerReviews to PullRequestReviewsEnforcement #744
Conversation
googlebot
added
the
cla: yes
GitHub.com support page about feature https://developer.github.com/v3/repos/branches/#update-branch-protection
|
Bump. The discrepancy came up as a result of changes in #637. As @shurcooL mentioned, we hadn't fully reviewed all the code in that pull request, so it's natural for this to occur. I believe this might also fix #664, since that has to do with the |
There was a problem hiding this comment.
LGTM.
Awaiting second LGTM before merging.
Thank you, @denniswebb and @elliott-beach!
|
It feels somewhat despotic to have the power to review PRs, but will proceed to do so, @gmlewis. |
|
Hi Elliott, I apologize for not discussing this with you first... are you open to reviewing PRs for this repo? You come highly recommended. 😄 |
github/repos.go
Outdated
| @@ -562,6 +562,8 @@ type PullRequestReviewsEnforcement struct { | |||
| DismissalRestrictions DismissalRestrictions `json:"dismissal_restrictions"` | |||
| // Specifies if approved reviews are dismissed automatically, when a new commit is pushed. | |||
| DismissStaleReviews bool `json:"dismiss_stale_reviews"` | |||
| // Specifies if an approved review is required in pull requests including files with a designated code owner. | |||
There was a problem hiding this comment.
To maintain the same style as the rest of the codebase, the comment should begin with
// RequireCodeOwnerReviews specifies...,
which is also in keeping with standard Go doc-comments.
There was a problem hiding this comment.
(That is a hard requirement for top level identifiers, but for struct fields, I think both ways are acceptable. This was consistent with the documentation for fields above.)
github/repos.go
Outdated
| @@ -572,6 +574,8 @@ type PullRequestReviewsEnforcementRequest struct { | |||
| DismissalRestrictionsRequest *DismissalRestrictionsRequest `json:"dismissal_restrictions"` | |||
| // Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. (Required) | |||
| DismissStaleReviews bool `json:"dismiss_stale_reviews"` | |||
| // Specifies if an approved review is required in pull requests including files with a designated code owner. | |||
|
Thank you! |
…#744) GitHub.com support page about feature https://developer.github.com/v3/repos/branches/#update-branch-protection
While working on terraform-providers/terraform-provider-github#50 I realized that this was missing.
GitHub.com support page about feature https://developer.github.com/v3/repos/branches/#update-branch-protection