-
Notifications
You must be signed in to change notification settings - Fork 2.1k
change org id to int64 in OrganizationsListOptions #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching this, @qinfchen!
LGTM.
@googlebot - please rescan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both RepositoryListAllOptions
and UserListOptions
already use int64
for their similar Since
field. Looks like we missed this one. Thanks for catching this.
LGTM.
CLAs look good, thanks! |
Thanks @qinfchen! |
Field Since in OrganizationsListOptions refers to an organization ID, so its type needs to be int64 to per prior decision in google#597. This is already the case in other similar structs such as RepositoryListAllOptions and UserListOptions. This is a breaking API change that is a part of resolving issue google#597. It should've been applied earlier, but we missed it (likely because the field doesn't have "ID" in its name, so it's harder to spot). Updates google#597.
Change org ID in OrganizationsListOptions to be consistent with the org id type