Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Switch counter metrics to use CUMULATIVE #19

Closed
wants to merge 1 commit into from
Closed

Switch counter metrics to use CUMULATIVE #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stackdriver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ func (s *Sink) report(ctx context.Context) {
Type: fmt.Sprintf("custom.googleapis.com/%s%s", s.prefix, name),
Labels: labels,
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Resource: resource,
Points: []*monitoringpb.Point{
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for CUMULATIVE the points also need to have a StartTime:

https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.metricDescriptors#metrickind

Expand Down
10 changes: 5 additions & 5 deletions stackdriver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ func TestSample(t *testing.T) {
Metric: &metricpb.Metric{
Type: "custom.googleapis.com/go-metrics/foo_bar_counter",
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Points: []*monitoringpb.Point{
{
Value: &monitoringpb.TypedValue{
Expand Down Expand Up @@ -402,7 +402,7 @@ func TestSample(t *testing.T) {
"env": "dev",
},
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Points: []*monitoringpb.Point{
{
Value: &monitoringpb.TypedValue{
Expand Down Expand Up @@ -438,7 +438,7 @@ func TestSample(t *testing.T) {
Metric: &metricpb.Metric{
Type: "custom.googleapis.com/go-metrics/foo_bar_counter",
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Points: []*monitoringpb.Point{
{
Value: &monitoringpb.TypedValue{
Expand Down Expand Up @@ -773,7 +773,7 @@ func TestExtract(t *testing.T) {
"method": "bar",
},
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Points: []*monitoringpb.Point{
{
Value: &monitoringpb.TypedValue{
Expand Down Expand Up @@ -914,7 +914,7 @@ func TestExtract(t *testing.T) {
"method": "baz",
},
},
MetricKind: metricpb.MetricDescriptor_GAUGE,
MetricKind: metricpb.MetricDescriptor_CUMULATIVE,
Points: []*monitoringpb.Point{
{
Value: &monitoringpb.TypedValue{
Expand Down