Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print OIDC token payload #222

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Print OIDC token payload #222

merged 1 commit into from
Jul 19, 2022

Conversation

jkl73
Copy link
Contributor

@jkl73 jkl73 commented Jul 18, 2022

Print the JSON payload for the OIDC token for the better
debuggability regarding the WIP policy.

Signed-off-by: Jiankun Lu jiankun@google.com

@jkl73 jkl73 requested review from josephlr and alexmwu July 18, 2022 22:23
@jkl73 jkl73 marked this pull request as ready for review July 18, 2022 22:23
josephlr
josephlr reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this approch, but I think we can have the JWT library do the parsing rather than trying to manually do it ourselves

launcher/container_runner.go Outdated Show resolved Hide resolved
launcher/container_runner.go Outdated Show resolved Hide resolved
@jkl73
Print OIDC token payload
2e324e5 
Print the JSON payload for the OIDC token for the better
debuggability regarding the WIP policy.

Signed-off-by: Jiankun Lu <jiankun@google.com>
josephlr
josephlr approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing the token twice isn't idea, but it should be fine. We can cleanup this later when we introduce a custom claims structure.

@josephlr
Copy link
Member

Lint failure is golangci/golangci-lint#2997

I think we can just change our CI configuration to work around it.

@josephlr josephlr merged commit 7296853 into google:master Jul 19, 2022
@josephlr
Copy link
Member

I ran the Lints locally, no issues, we will see if the CI issues persist.

@JoshuaKrstic JoshuaKrstic mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

@alexmwu alexmwu Awaiting requested review from alexmwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkl73 @josephlr