-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use crypto/ecdh
for tpmdirect
#327
Comments
Thanks for this issue! Yes, we should use this. |
I can write up a suggestion if we are fine with loosing support for a few curves. |
Hmm, more than P224? I think we'd have to discuss this in our team but if you sent a PR it would prompt such discussion, thanks! |
We'll largely be limited to the supported curves in Alternatively one can implement the |
Yeah, I will also take a look on my side to see if the Go crypto team would be receptive to adding those curves. |
It seems like
tpmdirect
is dealing with a bit of low-level stuff to accomplish ECDH which is mostly solved with the newcrypto/ecdh
package.Would it be a good idea to consider using this package maybe?
Currently the only missing part is
TPMECCNistP224
whichcrypot/ecdh
doesn't implement.The text was updated successfully, but these errors were encountered: