Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to 1.22 and golangci-lint to 1.56.2 #353

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

nckrss
Copy link
Contributor

@nckrss nckrss commented Feb 27, 2024

  • Update Go to 1.22
  • Update golangci-lint to 1.56.2
  • Correct new syntax lint errors
  • Refactor crypto that was using deprecated functions
  • Move golangci-lint run arguments to a configuration file

NOTE: Rather than disable the dot-imports rule for revive, an exclude directive should be used, however golangci/golangci-lint#4365 was not included in 1.56.2 so this PR disables a rule check that was added since 1.52. After the next release of golangci-lint the following can be applied:

diff --git a/.golangci.yml b/.golangci.yml
index 46a8a73..e4d95d5 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -10,7 +10,7 @@ linters-settings:
   revive:
     rules:
     - name: dot-imports
-      disabled: true
+      exclude: ["**/*_test.go"]
 issues:
   exclude-use-default: false
   exclude:

If this PR is merged before the next golangci-lint release I will create a new draft PR to capture the update.

@Foxboron
Copy link
Contributor

Foxboron commented Mar 1, 2024

6c3f164 solves #327

@nckrss
Copy link
Contributor Author

nckrss commented Mar 13, 2024

@chrisfenner are there other changes that you would like to see?

@chrisfenner
Copy link
Member

So sorry for the delays in review @nckrss, this and other active PRs here are in my backlog and I hope to get to it soon. Thank you for sending this!

Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this change! Sorry for the delays here; busy Q1 at the day job. I especially appreciate you taking the time to migrate to the new ecdh crypto APIs!

@chrisfenner chrisfenner merged commit 6b2397c into google:main Apr 11, 2024
4 checks passed
@nckrss nckrss deleted the update-dependencies branch April 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants