Fix TPM 1.2 migration #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some TPM 1.2-specific issues related to key migration and testing: - A bug in CreateWrapKey that uses an incorrect key to encrypt a key's `migrationAuth` value - Addition of `AuthorizeMigrationKey` and `CreateMigrationBlob` command functions to enable testing of migration auth bug fix - A bug fix in TakeOwnership that prevented successful authorization of the command - A session leak in a couple of TPM 1.2 tests (`TestOIAP` and `TestOSAP`) - Improvements to the TPM 1.2 tests to allow execution on a TPM that needs to be started up - Initial effort at documentation for running the TPM 1.2 tests against the IBM simulator
chrisfenner
requested review from
ChriMarMe,
flanfly,
josephlr,
twitchy-jsonp and
zaolin
as code owners
josephlr
approved these changes
Jul 23, 2020
twitchy-jsonp
approved these changes
Jul 23, 2020
twitchy-jsonp
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some TPM 1.2-specific issues related to key migration and testing, along with CVE-2020-8918:
migrationAuthvalueAuthorizeMigrationKeyandCreateMigrationBlobcommand functions to enable testing of migration auth bug fixTestOIAPandTestOSAP)