Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented and Tested ContextSave, ContextLoad #280

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Implemented and Tested ContextSave, ContextLoad #280

merged 2 commits into from
Jul 12, 2022

Conversation

matt-tsai
Copy link
Contributor

Added necessary Structures for ContextSave and ContextLoad. Implemented and tested both functions.

@matt-tsai matt-tsai requested a review from a team as a code owner May 26, 2022 22:01
alexmwu
alexmwu reviewed Jun 8, 2022
View reviewed changes
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/tpms/tpms.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Show resolved Hide resolved
chrisfenner
chrisfenner requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change that matters here is the "read public" suggestion (just to make the test safe for future use with "real" tpms

direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/structures/internal/structures.go Outdated Show resolved Hide resolved
direct/tpm2/combined_context_test.go Outdated Show resolved Hide resolved
direct/tpm2/combined_context_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I have only a couple minor concerns.

direct/tpm2/combined_context_test.go Outdated Show resolved Hide resolved
direct/tpm2/reflect.go Show resolved Hide resolved
direct/tpm2/combined_context_test.go Show resolved Hide resolved
@matt-tsai matt-tsai force-pushed the contextSaveLoad branch 2 times, most recently from 9a09be8 to f4c8bf9 Compare June 29, 2022 20:20
@chrisfenner chrisfenner merged commit 50ce973 into google:tpmdirect Jul 12, 2022
@matt-tsai matt-tsai deleted the contextSaveLoad branch July 12, 2022 20:14
@matt-tsai matt-tsai changed the title ContextSave and ContextLoad Implemented and Tested ContextSave, ContextLoad Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmwu alexmwu alexmwu left review comments

@chrisfenner chrisfenner chrisfenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-tsai @alexmwu @chrisfenner