Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the structure related to ECDAA #288

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

akakou
Copy link
Contributor

@akakou akakou commented Jul 1, 2022

Add the structure related to ECDAA.
Please read #285 (comment) .

  • TPMS_SCHEME_ECDAA added
  • A type alias for internal.TPMSSchemeECDAA as tpms.SchemeECDAA

Define `TPMS_SCHEME_ECDAA` as TPMSSchemeECDAA.
See definition in Part 2: Structures, section 11.1.18.
section 11.1.10 --> section 11.1.19
@akakou akakou requested a review from a team as a code owner July 1, 2022 06:39
@akakou
Copy link
Contributor Author

akakou commented Jul 4, 2022

@chrisfenner

I fixed the mistake, so could you confirm it?

@chrisfenner chrisfenner merged commit 8bd9361 into google:tpmdirect Jul 6, 2022
@chrisfenner
Copy link
Member

Looks great, thanks @akakou! Sorry for the delay. We had 2 company-wide days off due to the US holiday this weekend.

@akakou
Copy link
Contributor Author

akakou commented Jul 8, 2022

@chrisfenner
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants