Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented and Tested Certify #293

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Implemented and Tested Certify #293

merged 2 commits into from
Jul 13, 2022

Conversation

matt-tsai
Copy link
Contributor

No description provided.

@matt-tsai matt-tsai requested a review from a team as a code owner July 12, 2022 23:41
chrisfenner
chrisfenner requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I have only a couple very minor suggestions to improve the "example code" qualities of the test.

direct/tpm2/certify_test.go Outdated Show resolved Hide resolved
direct/tpm2/certify_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner requested changes Jul 13, 2022
View reviewed changes
direct/tpm2/certify_test.go Outdated Show resolved Hide resolved
direct/tpm2/certify_test.go Outdated Show resolved Hide resolved
chrisfenner
chrisfenner approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one more change (basically a nit about the contents of the nonce for the test, to make it clearer and more likely to catch certain types of bugs)

direct/tpm2/certify_test.go Outdated Show resolved Hide resolved
@chrisfenner chrisfenner merged commit d2289fb into google:tpmdirect Jul 13, 2022
@matt-tsai matt-tsai deleted the certify branch July 19, 2022 17:31
@matt-tsai matt-tsai changed the title Implemented and Tested TPM2_Certify Implemented and Tested Certify Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfenner chrisfenner chrisfenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-tsai @chrisfenner