rename tpmdirect to tpm2 and rename existing tpm2 as legacy/tpm2 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfenner
requested review from
alexmwu,
jkl73,
a team,
zaolin,
flanfly and
ChriMarMe
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the existing
tpm2package out tolegacy/tpm2and renames thedirectpackage astpm2.The KDFa and KDFe helpers from the legacy API (which are needed by the new API) are moved into the new API, with the legacy API calling into the new API for htem.
A small adapter layer is added at
tpm2/adapter.goto provide the API thatgo-tpm-tools/simulatorrequires. In the future, we can remove it aftergo-tpm-tools/simulatorhas been updated to use the new API.We may flatten the new
tpm2library's sub-librariesstructuresandcommandstogether intotpm2in a future change, perhaps as part of resolving #302.