-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tpm2.EvictControl #338
Conversation
cool, i wanted to take a stab at this at some point. Nice work 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent Joseph, thanks so much for the PR!
I have left two extremely minor comments to the actual code, other than that looks right.
Could you also please add a small unit test that uses simulator.OpenSimulator()
(see the tests
directory) that uses EvictControl to do something simple (like persist and then unpersist some object)?
5c33211
to
f3e992f
Compare
@chrisfenner Fixes and added test code! |
@jclab-joseph I see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right, will approve after goimports
f3e992f
to
610962e
Compare
610962e
to
6716d88
Compare
thank you @jclab-joseph for this change!! |
Fix #335
Sample Code: