Add golang.org/x/sys dependency to go.mod #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used in TPM FD polling and was missed previously. This should fix kokoro build too.
|
@tmroeder FYI, I'm vendoring golang.org/x/sys/unix, only because our kokoro environment doesn't support modules yet. Are you ok with that? |
|
OK, since @tmroeder is OOO, i'll merge this. But we can revert later if needed. |
|
I find it unfortunate that we have to pull in code and add an extra vendor directory so that we can poll a file description in exactly one function in tpmutil. Can we use syscall.Epoll* from the standard library instead? The epoll syscall can perform exactly the function of waiting for an fd to be ready. I glanced at #75, and I didn't see any discussion about this. |
|
Good point, x/sys/unix doesn't do as much magic as I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's used in TPM FD polling and was missed previously.
This should fix kokoro build too.