Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google sign in] Google One Tab appears in the DevTools area when data-use_fedcm_for_prompt enabled #928

Open
haru07 opened this issue Aug 28, 2023 · 6 comments

Comments

@haru07
Copy link

haru07 commented Aug 28, 2023

I have added data-use_fedcm_for_prompt for the Google One Tab FedCM as per the doc:
https://developers.google.com/identity/gsi/web/guides/fedcm-migration

When I open the DevTools with the dock at the bottom, the OAuth popup will appear outside the website:

  • appear in the DevTools's right corner
  • or outside of the Chrome window when you shrink the window height with the DevTools open.
@hermz365
Copy link

hermz365 commented Sep 8, 2023

Hi @haru07,

Could you please provide a screenshot or more details on how to reproduce the issues (e.g OS, Chrome versions, screen size, window size, etc.)?

Thanks,
Herman

@haru07
Copy link
Author

haru07 commented Sep 8, 2023

Hi @haru07,

Could you please provide a screenshot or more details on how to reproduce the issues (e.g OS, Chrome versions, screen size, window size, etc.)?

Thanks, Herman

image

Windows 10
Chrome Version 116.0.5845.180 (Official Build) (64-bit)
Chrome browser window: 1529 x 866

This happens when you open the DevTools regardless of window size but it appears outside the browser window when you resize.

@hermz365
Copy link

Hi @haru07,

Thank you for providing the details. The issue was logged, and you track the bug here https://bugs.chromium.org/p/chromium/issues/detail?id=1466122

Thanks,
Herman

@haru07
Copy link
Author

haru07 commented Oct 10, 2023

Hi @haru07,

Thank you for providing the details. The issue was logged, and you track the bug here https://bugs.chromium.org/p/chromium/issues/detail?id=1466122

Thanks, Herman

Hi,

Is the fedcm property still experimental? We haven't change the code but all of a sudden, it's now located on the left top corner of the Chrome browser and part of it is now outside the browser without opening the DevTools. Once we disable the fedcm property, it loads fine again.

@hermz365
Copy link

Hi @haru07,

Yes. FedCM is still in beta. You can read more info on the blog post - Announcing Federated Credential Management (FedCM) Beta for Google Identity Services.

Thanks

@haru07
Copy link
Author

haru07 commented Jun 7, 2024

Hi @haru07,

Yes. FedCM is still in beta. You can read more info on the blog post - Announcing Federated Credential Management (FedCM) Beta for Google Identity Services.

Thanks

I got an email from Google asking to migrate our applications to Google Identity Services One Tap FedCM. I have been putting this off because you can't control the position of the One Tap with FedCM enabled. The DevTools bug is still not fixed!

In the docs and what I usually see, it's suppose to appear on the top right corner of the browser. However, as of today June 7, it appears on the top left and part of it sticking outside the browser if you don't open Chrome maximized at 100% (shrink Chrome and move the browser to the right side on desktop). I thought it's my code, but I found a repo with a demo - https://github.com/BurakGur/google-one-tap and it behaves the same. Google is asking us to migrate but the position keeps on changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@hermz365 @haru07 and others