Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOE Sync 2019-12-20 #427

Merged
merged 2 commits into from
Dec 20, 2019
Merged

MOE Sync 2019-12-20 #427

merged 2 commits into from
Dec 20, 2019

Conversation

kluever
Copy link
Member

@kluever kluever commented Dec 20, 2019

This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.

Commits:

Fix a crash on c-style arrays in parameters

Fixes #374

acfe9c5


Add SBT plugin to readme

Fixes #391

56ec8f9

cushon and others added 2 commits December 20, 2019 09:17
Fixes #374

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=286467734
Fixes #391

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=286493206
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@kluever kluever merged commit 45e4afb into master Dec 20, 2019
@kluever kluever deleted the sync-master-2019/12/20 branch December 20, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on annotated array type
4 participants