Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explanation header to the difference summary #251

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

bjacotg
Copy link
Collaborator

@bjacotg bjacotg commented Jul 7, 2023

This will produce the following result, which makes more obvious what colors and +/- means.

Screenshot from 2023-07-07 14-02-05

This triggered the following refactoring:

  • Don't rely on left and right to describe the argument of edit_list.
  • Accept actual as first argument and expected as second (like in verify_that!)
  • Use Red vs Green instead of Red vs Blue for better contrast.
  • Use - for actual and + for expected. In a TTD process, expected is the ground truth that the code should generate, hence it reads as the recommendation: The code should remove the -lines and generate the+` lines.

@copybara-service copybara-service bot merged commit f8e2adc into main Jul 7, 2023
@gribozavr gribozavr deleted the colors branch February 17, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant