Reduce the visibility of most submodules of matchers.
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of public paths to each of the matcher functions. The functions are now visible only from the `matchers` module, and submodules containing those functions no longer appear in published documentation. Submodules containing macros which construct matchers remain public, since downstream crates still depend on these. This also reduces the visibility of some matcher structs which do not need to be public. Their constructor functions return `impl Matcher` and they provide no additional methods.
hovinen
force-pushed
the
reduce-module-visibility
branch
from
58d9177 to
6d07247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of public paths to each of the matcher functions. The functions are now visible only from the
matchersmodule, and submodules containing those functions no longer appear in published documentation.Submodules containing macros which construct matchers remain public, since downstream crates still depend on these.
This also reduces the visibility of some matcher structs which do not need to be public. Their constructor functions return
impl Matcherand they provide no additional methods.